Ticket #1519 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, with positive review] hg problem -- This should work but doesn't: sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw')

Reported by: was Owned by: was
Priority: major Milestone: sage-2.9
Component: user interface Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Doing 

sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw')

should work, but doesn't, because of the ?stuff at the end. Fix this.

How to test the patch: Try applying a patch or bundle by pasting in the URL to the raw format as in the example above.

Attachments

trac-1519.patch Download (1.4 KB) - added by was 5 years ago.

Change History

Changed 5 years ago by was

comment:1 Changed 5 years ago by was

  • Summary changed from hg problem -- This should work but doesn't: sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw') to [with patch] hg problem -- This should work but doesn't: sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw')

Note -- there is no easy way to doctest this, since it requires existence of a specific file on the internet with a funny ? in its filename..., and to apply that patch to a repository...

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from [with patch] hg problem -- This should work but doesn't: sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw') to [with patch, with positive review] hg problem -- This should work but doesn't: sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/1514/trac-1514.patch?format=raw')

looks good to me and is quite useful.

Cheers,

Michael

comment:3 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in 2.9.rc0.

Note: See TracTickets for help on using tickets.