Ticket #1514 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[with patch, with positive review] fix breakage and lameness in foo? and foo?? especially in the notebook.

Reported by: was Owned by: boothby
Priority: blocker Milestone: sage-2.9
Component: notebook Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

I'm sick of foo? or foo?? failing with tracebacks. They should never do that.

Attachments

trac-1514.patch Download (3.0 KB) - added by was 3 years ago.
trac-1514-fixdoctest.patch Download (0.9 KB) - added by cwitty 3 years ago.

Change History

Changed 3 years ago by was

Changed 3 years ago by was

  • priority changed from major to blocker
  • summary changed from fix breakage and lameness in foo? and foo?? especially in the notebook. to [with patch] fix breakage and lameness in foo? and foo?? especially in the notebook.

Changed 3 years ago by was

[9:43pm] cwitty-rvw-1514: wstein-rvw-1119, it looks like #1514 does not have any doctests for whatever bugs you are fixing?
[9:43pm] craigcitro: gmp comes before pari in the build order for libcsage
[9:44pm] wstein-rvw-1119: cwitty-1514 -- the buginess is that nothing works at all.
[9:44pm] wstein-rvw-1119: it's hard to have a doctest for that.
[9:44pm] wstein-rvw-1119: However, notice the first line of the patch, which turns *on* doctesting for the sageinspect.py file
[9:44pm] wstein-rvw-1119: So there are many new doctests as a result.
[9:45pm] wstein-rvw-1119: It's really a design change anyway -- to use the files in SAGE_ROOT/devel/sage/sage instead of SAGE_ROOT/local/lib/python/site-packages/sage/,
[9:45pm] wstein-rvw-1119: since for some reason often some .pyx files or other files that are relevant don't get copied over there.
[9:45pm] wstein-rvw-1119: But SAGE_ROOT/devel/sage/sage does.

Changed 3 years ago by cwitty

Changed 3 years ago by cwitty

  • summary changed from [with patch] fix breakage and lameness in foo? and foo?? especially in the notebook. to [with patch, with positive review] fix breakage and lameness in foo? and foo?? especially in the notebook.

Looks good to me; fixes doctests.

Apply both patches.

Changed 3 years ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged in 2.9.rc0.

Note: See TracTickets for help on using tickets.