Ticket #1459 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] make notebook ?? behavior like command line behavior

Reported by: mhansen Owned by: mhansen
Priority: minor Milestone: sage-2.9.1
Component: notebook Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

On the command-line, if a class docstring is not found, then the one from init is used. This does not happen in the notebook.

Attachments

1267-2.patch Download (2.0 KB) - added by mhansen 5 years ago.
1459-doc.patch Download (828 bytes) - added by rlm 5 years ago.
This fixes doctest formatting.

Change History

Changed 5 years ago by mhansen

Changed 5 years ago by rlm

This fixes doctest formatting.

comment:1 Changed 5 years ago by rlm

  • Summary changed from [with patch] make notebook ?? behavior like command line behavior to [with patch, negative review] make notebook ?? behavior like command line behavior

You should make sure to run doctests (no pun intended): 

**********************************************************************
File "sageinspect.py", line 404:
    sage: sage_getdoc(None)
Expected:
    ''
Got:
    'x.__init__(...) initializes x; see x.__class__.__doc__ for signature'
**********************************************************************

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, negative review] make notebook ?? behavior like command line behavior to [with patch, needs new review] make notebook ?? behavior like command line behavior

comment:3 Changed 5 years ago by mabshoff

mhansen also speculates that the patch above should also fix #1565.

Cheers,

Michael

comment:4 Changed 5 years ago by rlm

  • Status changed from new to closed
  • Resolution set to fixed
  • Summary changed from [with patch, needs new review] make notebook ?? behavior like command line behavior to [with patch, positive review] make notebook ?? behavior like command line behavior

merged in 2.9.1 rc0

added if obj is None: return ''

Note: See TracTickets for help on using tickets.