Ticket #1428 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, with positive review] add SVD method to matrix_complex_double_dense

Reported by: mhansen Owned by: mhansen
Priority: major Milestone: sage-2.10
Component: linear algebra Keywords:
Cc: dfdeshom@… Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

Hallo!

I tried to compute the SVD of a complex matrix (module
matrix.matrix_complex_double_dense), but I didn't found a function to
do so. However, real matrices (module matrix.matrix_real_double_dense)
support it. Is there really no way to compute a complex SVD? If I
remember correctly, at least the underlying library GSL supports
complex SVDs... What would I have to do to integrate those functions
into Sage?

Sander

Basically all that needs to be done is to translate the real code over to the complex case.

Attachments

1428.patch Download (9.1 KB) - added by mhansen 5 years ago.

Change History

Changed 5 years ago by mhansen

comment:1 Changed 5 years ago by mhansen

  • Owner changed from was to mhansen
  • Status changed from new to assigned
  • Summary changed from add SVD method to matrix_complex_double_dense to [with patch] add SVD method to matrix_complex_double_dense

comment:2 Changed 5 years ago by rlm

  • Summary changed from [with patch] add SVD method to matrix_complex_double_dense to [with patch, needs review] add SVD method to matrix_complex_double_dense

comment:3 Changed 5 years ago by dfdeshom

  • Cc dfdeshom@… added
  • Summary changed from [with patch, needs review] add SVD method to matrix_complex_double_dense to [with patch, with positive review] add SVD method to matrix_complex_double_dense

The patch looks great. I would suggest making an option that would just return S, instead of the tuple (U,S,V') since people that use this method tend to care more about S than anything else.

comment:4 Changed 5 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 2.10.alpha3

Note: See TracTickets for help on using tickets.