Ticket #1421 (closed enhancement: fixed)

Opened 6 years ago

Last modified 6 years ago

[with patch, with positive review] finer control in ECM interface

Reported by: zimmerma Owned by: was
Priority: minor Milestone: sage-2.9.1
Component: number theory Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

I have added a new method "one_curve" (maybe a better name can be found) to run exactly one curve (either ECM or P-1 or P+1). Also added examples for find_factor() method.

Attachments

7544.patch Download (4.5 KB) - added by zimmerma 6 years ago.
1421-pt2.patch Download (770 bytes) - added by craigcitro 6 years ago.

Change History

Changed 6 years ago by zimmerma

comment:1 Changed 6 years ago by was

code looks good -- if it passes tests, put it in.

comment:2 Changed 6 years ago by craigcitro

  • Summary changed from [with patch] finer control in ECM interface to [with patch, with positive review] finer control in ECM interface

Fixed one line in the original patch -- it creates a string to return as the error message, and then accidentally returns something other than that string (which I'm assuming wasn't the intended behavior).

Changed 6 years ago by craigcitro

comment:3 Changed 6 years ago by rlm

  • Status changed from new to closed
  • Resolution set to fixed

Merged in 2.9.1.alpha1

Note: See TracTickets for help on using tickets.