Ticket #14142 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Making mutable copies of simplicial complexes

Reported by: tscrim Owned by: tscrim
Priority: major Milestone: sage-5.8
Component: algebraic topology Keywords: mutable copy simplicial complex
Cc: jhpalmieri Work issues:
Report Upstream: N/A Reviewers: John Palmieri
Authors: Travis Scrimshaw Merged in: sage-5.8.beta2
Dependencies: Stopgaps:

Description (last modified by tscrim) (diff)

After #12587, one could make simplicial complexes immutable in order for them to be hashable. However there was no functionality to make mutable copies.

Attachments

trac_14142-mutable_copy_simplicial-ts.patch Download (4.7 KB) - added by tscrim 3 months ago.

Change History

comment:1 Changed 3 months ago by tscrim

  • Description modified (diff)

comment:2 Changed 3 months ago by tscrim

  • Status changed from new to needs_review

comment:3 Changed 3 months ago by jhpalmieri

This looks pretty good. I think it should be documented in one more place, maybe in the top-level docstring, in the mutability section, say around line 133.

comment:4 Changed 3 months ago by tscrim

I've added the doctests you requested.

Best,
Travis

comment:5 Changed 3 months ago by jhpalmieri

Great. Change "a mutable copies" (line 135) and I'll give it a positive review.

comment:6 Changed 3 months ago by tscrim

Done. I also changed the hash test to a better formatted test.

Changed 3 months ago by tscrim

comment:7 Changed 3 months ago by jhpalmieri

  • Status changed from needs_review to positive_review
  • Reviewers set to John Palmieri

comment:8 Changed 3 months ago by tscrim

Thank you for the review.

comment:9 Changed 3 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.8.beta2
Note: See TracTickets for help on using tickets.