Promotion on Tableaux should force its argument to be an Integer.

[nthiery]

The entries of a tableau are Integers::

    sage: T = Tableau([[1]])
    sage: type(T[0][0])
    <type 'sage.rings.integer.Integer'>

This invariant should be preserved by inverse promotion::

    sage: type(T.promotion_inverse(2)[0][0])
    <type 'sage.rings.integer.Integer'>

But this is currently not if the input is a plain int::

    sage: type(T.promotion_inverse(int(2))[0][0])
    <type 'int'>

[chapoton]

Could somebody please review this patch ?

[mhansen]

Could you add

    sage: type(T.promotion_inverse(int(2))[0][0])
    <type 'sage.rings.integer.Integer'>

as a doctest?

[chapoton]

Here is a new ticket, with a doctest added.

[chapoton]

rebased on 5.2

[nthiery]

I just had a look, and this sounds good. For consistency, can you put spaces on both sides of the = sign, and move this line just after the is_rectangular test (putting together all the argument checks/preprocessing).

Once done, you can set a positive review on my behalf (where is the patchbot?)

Ah: it depends syntactically on #13074. I just moved your patch right after it in the queue; please run the tests with them applied.

Thanks!

Cheers,

Nicolas

[chapoton]

I have made the changes, and the tests pass. I do not understand whether I should add the dependency to #13074 or not.

[nthiery]

Unless you commute this patch past #13074, yes it should be a dependency (done)