Ticket #13100 (closed enhancement: fixed)

Opened 12 months ago

Last modified 11 months ago

EllipticCurve_from_j (over QQ) should not always compute minimal twist

Reported by: cremona Owned by: cremona
Priority: minor Milestone: sage-5.3
Component: elliptic curves Keywords: elliptic curve construction
Cc: roed, vbraun Work issues:
Report Upstream: N/A Reviewers: David Roe
Authors: John Cremona Merged in: sage-5.3.beta0
Dependencies: #13109 Stopgaps:

Description (last modified by jhpalmieri) (diff)

Currently when constructing an elliptic curve from a j-invariant over QQ, a curve with minimal conductor is created (the so-called "minimal twist"). This could be expensive since it involves factoring j and j-1728, so an option to *not* find the minimal twist should be allowed, with the current behaviour as default for backwards compatibility.

For example: 

sage: EllipticCurve(j=2^256+1)

currently triggers factorization of F_8 (which is quite quick) but also F_8-1728 (which is not).

Apply trac13100-elliptic-rebased.patch Download.

Attachments

trac13100-elliptic.patch Download (7.4 KB) - added by cremona 12 months ago.
Applies to 5.1.beta3
trac13100-rebase-on-13109.patch Download (1.4 KB) - added by jhpalmieri 12 months ago.
fix a deprecation
trac13100-elliptic-rebased.patch Download (7.7 KB) - added by jhpalmieri 12 months ago.

Change History

Changed 12 months ago by cremona

Applies to 5.1.beta3

comment:1 Changed 12 months ago by cremona

  • Cc roed added
  • Status changed from new to needs_review
  • Authors set to John Cremona

The patch fixes this, and also the issue at #11773 which can be closed as a duplicate.

comment:2 follow-up: ↓ 3 Changed 12 months ago by roed

  • Status changed from needs_review to needs_work

This looks fine to me. I have no idea what the doctest failing on patchbot is about. Patchbot is also complaining about trailing whitespace....

comment:3 in reply to: ↑ 2 Changed 12 months ago by cremona

Replying to roed:

This looks fine to me. I have no idea what the doctest failing on patchbot is about. Patchbot is also complaining about trailing whitespace....

I removed trailing whitespace on lines I edited (or nearby) but not on the whole file as that makes it harder for reviewers to see what has changed. Of course I could go back and remove the rest. Does patchbot tell us what tests actually fail?

comment:4 follow-up: ↓ 5 Changed 12 months ago by roed

  • Status changed from needs_work to positive_review

The patchbot will tell you if you click on the yellow disc (or whatever other color it might be), then click on "shortlog."

I ran the tests on my own machine and am not getting the same failure patchbot is. Since I have no idea why your changes would cause a problem in sage.misc.trace, I'm going to give it a positive review.

comment:5 in reply to: ↑ 4 Changed 12 months ago by cremona

Replying to roed:

The patchbot will tell you if you click on the yellow disc (or whatever other color it might be), then click on "shortlog."

I ran the tests on my own machine and am not getting the same failure patchbot is. Since I have no idea why your changes would cause a problem in sage.misc.trace, I'm going to give it a positive review.

Thanks. I agree that the failure reported by patchbot has nothing to do with this ticket.

comment:6 Changed 12 months ago by jdemeyer

  • Reviewers set to David Roe
  • Milestone changed from sage-5.1 to sage-5.2

comment:7 Changed 12 months ago by jhpalmieri

  • Cc vbraun added
  • Status changed from positive_review to needs_work
  • Dependencies set to #13109
  • Description modified (diff)

This needs to be rebased to #13109. Patch attached, and I've cc'ed Volker, who should be able to review it quickly.

Changed 12 months ago by jhpalmieri

fix a deprecation

comment:8 Changed 12 months ago by jhpalmieri

  • Status changed from needs_work to needs_review

comment:9 follow-up: ↓ 10 Changed 12 months ago by vbraun

John, trac13100-elliptic.patch conflicts with my version of #13109.

comment:10 in reply to: ↑ 9 Changed 12 months ago by cremona

Replying to vbraun:

John, trac13100-elliptic.patch conflicts with my version of #13109.

I understand, but doesn't Joh Palmieri's patch fix it (thanks John)?

Changed 12 months ago by jhpalmieri

comment:11 Changed 12 months ago by jhpalmieri

  • Description modified (diff)

Sorry, try this one instead. (I got this one confused with another ticket dealing with elliptic curves.)

comment:12 Changed 12 months ago by jhpalmieri

  • Status changed from needs_review to positive_review

This is just a rebasing, so I don't think it needs review.

comment:13 Changed 12 months ago by jdemeyer

  • Milestone changed from sage-5.2 to sage-pending

comment:14 Changed 11 months ago by jdemeyer

  • Milestone changed from sage-pending to sage-5.3

comment:15 Changed 11 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.3.beta0
Note: See TracTickets for help on using tickets.