Ticket #13040 (closed defect: duplicate)

Opened 12 months ago

Last modified 11 months ago

Polybori spkg: allow CC to contain multiple words

Reported by: rohana Owned by: GeorgSWeber
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords: sd40.5
Cc: AlexanderDreyer Work issues:
Report Upstream: Fixed upstream, in a later stable release. Reviewers: R. Andrew Ohana
Authors: Merged in:
Dependencies: #12963 Stopgaps:

Description (last modified by rohana) (diff)

Currently polybori errors if CC has multiple words in it.

Fixed in #13124.

Change History

comment:1 Changed 12 months ago by rohana

  • Status changed from new to needs_review
  • Description modified (diff)
  • Authors set to R. Andrew Ohana

comment:2 Changed 12 months ago by rohana

  • Description modified (diff)

comment:3 Changed 12 months ago by rohana

  • Dependencies set to #12963

comment:4 Changed 12 months ago by AlexanderDreyer

  • Cc AlexanderDreyer added

comment:5 Changed 12 months ago by AlexanderDreyer

In #12963 a possible issue of the patch is mentioned.

comment:6 Changed 12 months ago by AlexanderDreyer

Unfortunately, the suggested patch reintroduced some flaws of os.popen, in particular the one of #12963. Please use the upstream patch from  https://bitbucket.org/brickenstein/polybori/changeset/ae7a475cd687 instead.

comment:7 Changed 12 months ago by kini

Indeed, it's caused by p3.

Diff between logs of p2 and logs of p3:  http://wstein.org/home/keshav/files/polybori-log.3.diff.xz

comment:8 Changed 12 months ago by AlexanderDreyer

  • Status changed from needs_review to needs_work

comment:9 Changed 11 months ago by AlexanderDreyer

  • Report Upstream changed from N/A to Fixed upstream, in a later stable release.

Meanwhile, #13124 had superseded this issue, so I think this ticket should be marked as a duplicate.

comment:10 Changed 11 months ago by rohana

  • Status changed from needs_work to positive_review
  • Reviewers set to R. Andrew Ohana
  • Milestone changed from sage-5.1 to sage-duplicate/invalid/wontfix
  • Description modified (diff)
  • Authors R. Andrew Ohana deleted

Looks good.

comment:11 Changed 11 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to duplicate
Note: See TracTickets for help on using tickets.