Ticket #13007 (closed task: fixed)
Update to Frobby 0.9.0
| Reported by: | mhansen | Owned by: | tbd |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.1 |
| Component: | packages: experimental | Keywords: | sd40.5 |
| Cc: | drkirkby | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Benjamin Jones |
| Authors: | Mike Hansen | Merged in: | |
| Dependencies: | Stopgaps: |
Description (last modified by mhansen) (diff)
Change History
comment:1 Changed 12 months ago by mhansen
- Status changed from new to needs_review
- Description modified (diff)
comment:2 Changed 12 months ago by benjaminfjones
- Keywords sd40.5 added
- Reviewers set to Benjamin Jones
The new spkg builds successfully using gcc 4.6.3 and SAGE_CHECK=yes on x86_64 debian squeeze. I'll test some other archs / platforms tomorrow, but looks good so far!
comment:3 Changed 12 months ago by benjaminfjones
The new spkg builds successfully using gcc 4.7.0 and SAGE_CHECK=yes on x86_64 Fedora 16 (skynet/eno). I'll test ubuntu and call it a wrap.
comment:4 Changed 12 months ago by benjaminfjones
- Status changed from needs_review to positive_review
Building with SAGE_CHECK=yes on Ubunutu with gcc 4.4.3 (redhawk) works as well. I'm giving this a positive review.
comment:7 Changed 12 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
comment:8 Changed 12 months ago by schilly
i just added it to the experimental spkges + updated master mirror
comment:9 Changed 12 months ago by kcrisman
See also #8515 - Ben, do you have access to one of those Solaris machines?
I just had it pass with SAGE_CHECK on Mac OS. However, the tests in sage/interfaces/frobby.py don't pass.
sage -t --optional "devel/sage/sage/interfaces/frobby.py"
**********************************************************************
File "/Users/.../sage-5.1.beta1-flask/devel/sage/sage/interfaces/frobby.py", line 42:
sage: frobby("analyze", input="vars x,y,z;[x^2,x*y];", #optional
options=["lcm", "iformat monos", "oformat 4ti2"]) #optional
Expected:
'x^2*y\n'
Got:
' 2 1 0\n\n2 generators\n3 variables\n'
**********************************************************************
File "/Users/.../sage-5.1.beta1-flask/devel/sage/sage/interfaces/frobby.py", line 47:
sage: frobby("do_dishes") #optional
Expected:
Traceback (most recent call last):
...
RuntimeError: Frobby reported an error:
ERROR: Unknown action "do_dishes".
Got:
Traceback (most recent call last):
RuntimeError: Frobby reported an error:
ERROR: No action has the prefix "do_dishes".
<BLANKLINE>
**********************************************************************
File "/Users/.../sage-5.1.beta1-flask/devel/sage/sage/interfaces/frobby.py", line 96:
sage: decom = frobby.irreducible_decomposition(id) #optional
Exception raised:
raise RuntimeError("Format error: incorrect matrix dimensions.")
RuntimeError: Format error: incorrect matrix dimensions.
**********************************************************************
File "/Users/.../sage-5.1.beta1-flask/devel/sage/sage/interfaces/frobby.py", line 98:
sage: set(decom) == set(true_decom) # use sets to ignore order #optional
Exception raised:
set(decom) == set(true_decom) # use sets to ignore order #optional###line 98:
sage: set(decom) == set(true_decom) # use sets to ignore order #optional
NameError: name 'decom' is not defined
**********************************************************************
File "/Users/.../sage-5.1.beta1-flask/devel/sage/sage/interfaces/frobby.py", line 117:
sage: for ring in rings: #optional
id1 = ring.ideal(Integer(1)) #optional
decom1 = frobby.irreducible_decomposition(id1) #optional
allOK = allOK and decom1 == [id1] #optional
Exception raised:
RuntimeError: Format error: encountered non-number.
*******************************************************************
Otherwise we could really make it an optional package again after all this testing if it worked on Solaris.
comment:10 Changed 12 months ago by benjaminfjones
- Cc drkirkby added
I don't have access to drkirkby's machines. Maybe we can get him to test the package out. In any case I don't know anything about Solaris or SPARC platforms.
