Ticket #12981 (closed enhancement: fixed)

Opened 13 months ago

Last modified 12 months ago

Ljubljana Graph

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.1
Component: graph theory Keywords: sd40.5
Cc: wdj, kini, dimpase Work issues:
Report Upstream: N/A Reviewers: Keshav Kini
Authors: Nathann Cohen Merged in: sage-5.1.beta4
Dependencies: #12942, #12945, #12952, #12971, #12980 Stopgaps:

Description

Yeahhhhhhh !! For this one I found a pretty embedding ! :-)

Nathann

Attachments

trac_12981.patch Download (4.0 KB) - added by ncohen 13 months ago.
trac_12981.reviewer.patch Download (2.5 KB) - added by kini 13 months ago.
apply to $SAGE_ROOT/devel/sage

Change History

Changed 13 months ago by ncohen

comment:1 Changed 13 months ago by ncohen

  • Status changed from new to needs_review

Changed 13 months ago by kini

apply to $SAGE_ROOT/devel/sage

comment:2 Changed 13 months ago by kini

  • Keywords sd40.5 added
  • Reviewers set to Keshav Kini

Here is a review patch! This time I see you have already added "Graph" to the function name :) I fixed a typo in the docstring, made the function microscopically faster, and removed an unreachable return statement.

If you agree with the review patch, we can set this to positive review.

patchbot: apply trac_12981.patch trac_12981.reviewer.patch

comment:3 Changed 13 months ago by ncohen

  • Status changed from needs_review to positive_review

I regret that you removed my i+=0, for it is always useful to add these statements at random places in the code. Otherwise, thank you again for this review :-)

Nathann

comment:4 Changed 13 months ago by kini

:)

comment:5 Changed 12 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.1.beta4
Note: See TracTickets for help on using tickets.