Ticket #12972 (closed defect: fixed)

Opened 13 months ago

Last modified 10 months ago

Fix small bug in elliptic curve saturation

Reported by: cremona Owned by: cremona
Priority: major Milestone: sage-5.4
Component: elliptic curves Keywords: saturation
Cc: Work issues:
Report Upstream: N/A Reviewers: Volker Braun
Authors: John Cremona Merged in: sage-5.4.beta1
Dependencies: Stopgaps:

Description

The saturation() method for elliptic curves of Q has a small bug: a variable (which will most often notbe used) was not initialised. At the same time I changed two parameter in the saturation code.

Attachments

Qsat.patch Download (1.4 KB) - added by cremona 13 months ago.
Applies t.o 5.0

Change History

Changed 13 months ago by cremona

Applies t.o 5.0

comment:1 Changed 13 months ago by cremona

  • Status changed from new to needs_review

I have been using this code (with the patch) for many thousands of curves over several months. I no longer remember which curve actually triggered the bug, so I have not added a doctest. WIth a new release I realised that I had never submitted the patch for review (but I will go on using it every day even if reviewers don't like the lack of doctest!).

comment:2 follow-up: ↓ 4 Changed 10 months ago by vbraun

Looks good to me!

comment:3 Changed 10 months ago by vbraun

  • Status changed from needs_review to positive_review
  • Reviewers set to Volker Braun

comment:4 in reply to: ↑ 2 Changed 10 months ago by cremona

Replying to vbraun:

Looks good to me!

thanks!

comment:5 Changed 10 months ago by jdemeyer

  • Milestone changed from sage-5.3 to sage-5.4

comment:6 Changed 10 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.4.beta1
Note: See TracTickets for help on using tickets.