Ticket #12937 (closed defect: fixed)

Opened 12 months ago

Last modified 12 months ago

sqlite sometimes picks up the wrong libraries (e.g., readline) since we forgot to set LDFLAGS

Reported by: was Owned by: tbd
Priority: major Milestone: sage-5.1
Component: packages: standard Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: John Connor
Authors: William Stein Merged in: sage-5.1.beta1
Dependencies: Stopgaps:

Description (last modified by was) (diff)

On certain systems, e.g., Fedora with libreadline.so.5 systemwide, when building sqlite, the sqlite3 binary points to libreadline.so.5. However, Sage ships libreadline.so.6. The fix is trivial -- just define LDFLAGS, as we always should do. (Why we don't in ./install is beyond me...)

 http://wstein.org/patches/sqlite-3.7.5.p1.spkg

Attachments

sqlite-3.7.5.p1.diff Download (1.4 KB) - added by jdemeyer 12 months ago.
Diff for the sqlite spkg. For reference / review only.

Change History

comment:1 Changed 12 months ago by was

  • Status changed from new to needs_review
  • Description modified (diff)
  • Authors set to William Stein

comment:2 Changed 12 months ago by JohnConnor

  • Status changed from needs_review to positive_review
  • Reviewers set to John Connor

comment:3 Changed 12 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.1.beta1

Changed 12 months ago by jdemeyer

Diff for the sqlite spkg. For reference / review only.

comment:4 Changed 12 months ago by jdemeyer

Obviously, -I $SAGE_LOCAL/lib should be -L $SAGE_LOCAL/lib. This couldn't have solved any problem.

Note: See TracTickets for help on using tickets.