Memory leaks with Cliquer

[ncohen]

Geoff reported on  http://ask.sagemath.org/question/1170/memory-blowup-with-milp memory leaks in Sage. Turns out there were two to solve, and one of them was fixed in #12903. The other one comes from Cliquer and is solved with this patch. Here's what it does :

• Solves memory leaks reported by Geoff
• Incidentally updates Cliquer to version 1.21
• Incidentally removes Sage's code that was formerly directly inserted in the original Cliquer files. This code is now inserted during the SPKG installation from patches located in the SPKG's patches/ folder.

As a result, no one should be scared anymore of running the following lines :

for i in range(2000):
    print get_memory_usage()
    _ = graphs.RandomGNP(30,.2).cliques_maximum()

for i in range(2000):
    print get_memory_usage()
    _ = graphs.RandomGNP(30,.2).clique_number()

for i in range(2000):
    print get_memory_usage()
    _ = graphs.RandomGNP(30,.2).clique_maximum()

Apply:

• trac_12905.patch

Install the new version of Cliquer:

•  http://www.steinertriples.fr/ncohen/cliquer-1.21.p0.spkg

[jdemeyer]

Please fill in your real name as Author.

[dcoudert]

I don't know how to install the new package. Using the ìnstall_package` method, I get either a re-install of cliquer-1.2.p11, or it answers there is no package name with cliquer-1.21.p11. I tried copying the package to the standard and the optimal package directories without success.

[dcoudert]

OK, the method for installing the package is

sage -i <package.spkg>

or when the package is already installed (as for cliquer):

sage -f <package.spkg>

The patch is working perfectly and the memory usage remains constant. Excellent! I give positive review.

[jdemeyer]

The spkg should be rebased on cliquer-1.2.p11.spkg (which is in sage-5.1 or later).

Also: normally, the version number of your spkg should be cliquer-1.21.p0.spkg (not p11).

[ncohen]

New spkg :  http://www.steinertriples.fr/ncohen/cliquer-1.21.p0.spkg

Should be fine now :-)

God, I had almost forgotten this trac ticket ^^;

Nathann

[dcoudert]

The patch is still working perfectly.

I haven't changes the milestone but it should certainly be 5.5

[ncohen]

WouhouuuuuuUUU !! Thanks :-)

Nathann

[jdemeyer]

This should be rebased to #13188.

[ncohen]

Done !