Ticket #12818 (closed defect: duplicate)

Opened 14 months ago

Last modified 10 months ago

Building polybori under FreeBSD

Reported by: stephen Owned by: pjeremy
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: porting: BSD Keywords: FreeBSD polybori
Cc: AlexanderDreyer Work issues:
Report Upstream: Fixed upstream, in a later stable release. Reviewers: Stephen Montgomery-Smith, Alexander Dreyer, Karl-Dieter Crisman
Authors: Merged in:
Dependencies: #13124 Stopgaps:

Description (last modified by AlexanderDreyer) (diff)

I need this patch to build under FreeBSD: 

--- src/polybori-0.8.0/Cudd/cudd/cudd.h-orig	2012-02-09 03:18:02.000000000 +0000
+++ src/polybori-0.8.0/Cudd/cudd/cudd.h	2012-02-09 03:19:20.000000000 +0000
@@ -82,6 +82,12 @@
 
 #endif
 
+#ifdef __cplusplus
+#include <cstdio>
+#else
+#include <stdio.h>
+#endif
+
 #ifdef __cplusplus
 extern "C" {
 #endif

This patch should be harmless to all builds under other OS.

Duplicate of #13124.

Attachments

Cudd.cudd.cudd.h Download (306 bytes) - added by stephen 14 months ago.
patch for cudd.h
spkg-patch-polybori-0.8.0.p2_-_spkg_install Download (436 bytes) - added by stephen 14 months ago.
patch for spkg-install

Change History

Changed 14 months ago by stephen

patch for cudd.h

Changed 14 months ago by stephen

patch for spkg-install

comment:1 Changed 13 months ago by stephen

  • Owner changed from tbd to pjeremy
  • Type changed from PLEASE CHANGE to defect
  • Component changed from PLEASE CHANGE to FreeBSD

comment:2 Changed 11 months ago by AlexanderDreyer

  • Cc AlexanderDreyer added
  • Report Upstream changed from N/A to Fixed upstream, in a later stable release.

Thanks, the patch will be part of polybori-0.8.2, see  https://bitbucket.org/brickenstein/polybori/changeset/8aed782d9baf .

comment:3 Changed 11 months ago by kcrisman

  • Reviewers set to Alexander Dreyer
  • Authors set to Stephen Montgomery-Smith

Is there an ETA on when that will be in Sage, or should we try to make an spkg update?

comment:4 Changed 11 months ago by AlexanderDreyer

Meanwhile the new spkg is at #13124. Feel free to try it out. If it solves you problem, this one may be considered as a duplicate of #13124.

comment:5 Changed 11 months ago by kcrisman

  • Status changed from new to needs_review
  • Reviewers changed from Alexander Dreyer to Alexander Dreyer, Karl-Dieter Crisman

I can confirm that the patch in question is included in #13124. Since this is definitely the only thing from  the FreeBSD port list from polybori, I think that we can close this ticket.

comment:6 Changed 11 months ago by kcrisman

  • Status changed from needs_review to positive_review
  • Dependencies set to #13124

comment:7 Changed 11 months ago by kcrisman

  • Milestone changed from sage-5.1 to sage-5.2

comment:8 Changed 11 months ago by stephen

I can confirm that ticket #13124 fixes this problem for FreeBSD.

comment:9 Changed 11 months ago by AlexanderDreyer

  • Description modified (diff)
  • Milestone changed from sage-5.2 to sage-duplicate/invalid/wontfix

Duplicate of #13124.

comment:10 Changed 10 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Reviewers changed from Alexander Dreyer, Karl-Dieter Crisman to Stephen Montgomery-Smith, Alexander Dreyer, Karl-Dieter Crisman
  • Resolution set to duplicate
  • Authors Stephen Montgomery-Smith deleted
Note: See TracTickets for help on using tickets.