Ticket #12755 (closed defect: fixed)

Opened 15 months ago

Last modified 15 months ago

Make coverage remove return types from Cython functions

Reported by: jdemeyer Owned by: leif
Priority: minor Milestone: sage-5.0
Component: scripts Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Mike Hansen
Authors: Jeroen Demeyer Merged in: sage-5.0.beta12
Dependencies: Stopgaps:

Description (last modified by jdemeyer) (diff)

A function like 

cpdef long foo()

will confuse the coverage script: it will look for "long foo" in the docstring instead of "foo".

Apply 12755_coverage_cython.patch Download to the SCRIPTS repository.

Attachments

12755_coverage_cython.patch Download (889 bytes) - added by jdemeyer 15 months ago.

Change History

comment:1 Changed 15 months ago by jdemeyer

  • Status changed from new to needs_review
  • Description modified (diff)

comment:2 Changed 15 months ago by jdemeyer

  • Description modified (diff)

Changed 15 months ago by jdemeyer

comment:3 Changed 15 months ago by mhansen

  • Status changed from needs_review to positive_review
  • Reviewers set to Mike Hansen

Looks good.

comment:4 Changed 15 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta12
Note: See TracTickets for help on using tickets.