Ticket #12747 (closed defect: fixed)

Opened 14 months ago

Last modified 14 months ago

is_R_algebra is useless and wrong and should be deleted

Reported by: JStarx Owned by: AlexGhitza
Priority: minor Milestone: sage-5.0
Component: algebra Keywords: algebra, all.py
Cc: Work issues:
Report Upstream: N/A Reviewers: David Loeffler
Authors: Jim Stark Merged in: sage-5.0.beta12
Dependencies: Stopgaps:

Description (last modified by JStarx) (diff)

In algebras/all.py we find the following function: 

def is_R_algebra(Q, R):
    # TODO: do something nontrivial when morphisms are defined.
    return True

A search of the source shows that this function is not used anywhere else in sage, and good thing too, cause it's obviously wrong. The attached patch deletes this function.

Attachments

trac12747-newline.patch Download (715 bytes) - added by davidloeffler 14 months ago.
JStarx's patch with newline

Change History

comment:1 Changed 14 months ago by JStarx

  • Status changed from new to needs_review

comment:2 Changed 14 months ago by JStarx

  • Description modified (diff)

Changed 14 months ago by davidloeffler

JStarx's patch with newline

comment:3 Changed 14 months ago by davidloeffler

  • Status changed from needs_review to positive_review
  • Reviewers set to David Loeffler

Apply trac12747-newline.patch

(for the patchbot). This function is totally laughable, and the patch looks fine except for one breathtakingly trivial niggle: in Sage we generally like code files to end with a newline character, so I restored the newline you had shaved off the end of algebras/all.py. I guess that single newline doesn't merit a re-review, so I'm setting this to positive review.

comment:4 Changed 14 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta12
Note: See TracTickets for help on using tickets.