Ticket #12742 (closed defect: fixed)
matplotlib must be a dependency of cvxopt
| Reported by: | dimpase | Owned by: | tbd |
|---|---|---|---|
| Priority: | blocker | Milestone: | sage-5.0 |
| Component: | packages: standard | Keywords: | cvxopt matplotlib |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | Julien Puydt |
| Authors: | Jeroen Demeyer | Merged in: | sage-5.0.beta11 |
| Dependencies: | #10492 | Stopgaps: |
Description (last modified by jdemeyer) (diff)
see https://groups.google.com/d/msg/sage-release/4qh8c9wWJfI/XgVZxmu7zu8J
SAGE_CHECK will fail on cvxopt if pylab (part of matplotlib) is not available.
Apply 12742_cvxopt_deps.patch to SAGE_ROOT.
Attachments
-
12742_cvxopt_deps.patch
(779 bytes) -
added by jdemeyer 14 months ago.
Change History
comment:1 Changed 14 months ago by kcrisman
- Keywords matplotlib added; mathplotlib removed
- Description modified (diff)
- Work issues changed from make mathplotlib a pre-req for cvxopt to make matplotlib a pre-req for cvxopt
comment:2 Changed 14 months ago by jdemeyer
- Priority changed from major to blocker
- Dependencies set to #10492
- Summary changed from mathplotlib must be a dependence of cvxopt to matplotlib must be a dependence of cvxopt
comment:3 Changed 14 months ago by jdemeyer
- Status changed from new to needs_review
- Work issues make matplotlib a pre-req for cvxopt deleted
- Summary changed from matplotlib must be a dependence of cvxopt to matplotlib must be a dependency of cvxopt
- Description modified (diff)
- Authors set to Jeroen Demeyer
comment:4 Changed 14 months ago by Snark
- Status changed from needs_review to positive_review
This patch looks good.
comment:6 Changed 14 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-5.0.beta11
comment:7 follow-up: ↓ 9 Changed 14 months ago by leif
There should at least be a comment that (building) CVXOPT does not depend on matplotlib; if upstream fixes the tests (e.g. by skipping some in case matplotlib is not [yet] available), this dependency should get removed again.
Also CVXOPT's SPKG.txt should get updated accordingly ("Dependencies" and "Special Update/Build? Instructions" sections).
comment:8 Changed 14 months ago by jhpalmieri
See #12784 for a trivial-to-review followup.
Adding a comment to cvxopt's SPKG.txt should perhaps also be done. The same could be said for sagetex's SPKG.txt, which doesn't explain that testing the package will fail unless basically all of Sage is installed first. Someone else can deal with those.
