Ticket #12712 (closed defect: fixed)

Opened 14 months ago

Last modified 14 months ago

update optional spkg 'database_gap'

Reported by: jhpalmieri Owned by: tbd
Priority: blocker Milestone: sage-5.0
Component: packages: optional Keywords:
Cc: dimpase Work issues:
Report Upstream: N/A Reviewers: Jeroen Demeyer, Dmitrii Pasechnik
Authors: John Palmieri Merged in:
Dependencies: Stopgaps:

Description

Because of #10492, the optional package database_gap no longer installs correctly. Here is a new spkg:

Attachments

trac_12712-database-gap.patch Download (3.6 KB) - added by jhpalmieri 14 months ago.
patch for spkg, for review only

Change History

comment:1 Changed 14 months ago by jdemeyer

I'm not convinced by this spkg-install script.

Why not detect the GAP version using 

GAP=`echo 'Print(Concatenation("gap-", GAPInfo.Version));' | gap -q`

I guess this is the most robust solution.

comment:2 Changed 14 months ago by jhpalmieri

That looks much better, so I'll make that change. (Another option would be to look at directories with names SAGE_LOCAL/lb/gap-*, since that's why the variable is needed: it installs things in that directory.)

comment:3 Changed 14 months ago by jhpalmieri

  • Status changed from new to needs_review

comment:4 Changed 14 months ago by jhpalmieri

  • Dependencies set to #10492

comment:5 Changed 14 months ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Dependencies #10492 deleted

Why does this depend on #10492? It's the other way around I guess.

comment:6 Changed 14 months ago by jdemeyer

Installed the old GAP-4.4.10 package from Sage-4.2, installed this database, all without #10492. Success.

comment:7 Changed 14 months ago by jhpalmieri

I guess you're right, #10492 should depend on this. (I think it's reasonable for failure of optional spkgs to lead to blockers, since optional spkgs are supposed to work on all supported platforms.)

comment:8 Changed 14 months ago by jdemeyer

Line 68 of spkg-install: replace "$SAGE_ROOT/sage -gap" by "gap".

SPKG.txt: replace 

== Change log ==

by 

== Changelog ==

Changed 14 months ago by jhpalmieri

patch for spkg, for review only

comment:9 follow-up: ↓ 10 Changed 14 months ago by jhpalmieri

I made that change, as well as other minor clean up in SPKG.txt.

comment:10 in reply to: ↑ 9 Changed 14 months ago by dimpase

  • Status changed from needs_review to positive_review
  • Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, Dmitrii Pasechnik

Replying to jhpalmieri:

I made that change, as well as other minor clean up in SPKG.txt.

Good. Positive review.

comment:11 Changed 14 months ago by schilly

i just put the spkg on the severs.

comment:12 Changed 14 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed

comment:13 Changed 14 months ago by jdemeyer

gap_packages has the same problem: see #12758.

Note: See TracTickets for help on using tickets.