Ticket #12669 (closed defect: fixed)

Opened 14 months ago

Last modified 14 months ago

Conductor of trivial Dirichlet character has type int

Reported by: johanbosman Owned by: craigcitro
Priority: major Milestone: sage-5.0
Component: modular forms Keywords: dirichlet characters
Cc: Work issues:
Report Upstream: N/A Reviewers: David Loeffler
Authors: Mike Hansen Merged in: sage-5.0.beta11
Dependencies: Stopgaps:

Description 

sage: G.<a, b> = DirichletGroup(20)
sage: type(a.conductor())
<type 'sage.rings.integer.Integer'>
sage: type(G(1).conductor())
<type 'int'>

It should of course return something of type Integer.

Attachments

trac_12669.patch Download (1.2 KB) - added by mhansen 14 months ago.

Change History

Changed 14 months ago by mhansen

comment:1 Changed 14 months ago by mhansen

  • Status changed from new to needs_review
  • Authors set to Mike Hansen

comment:2 Changed 14 months ago by davidloeffler

  • Status changed from needs_review to positive_review
  • Reviewers set to David Loeffler

This looks fine, and patchbot's happy.

comment:3 Changed 14 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta11
Note: See TracTickets for help on using tickets.