Ticket #12651 (closed defect: fixed)

Opened 14 months ago

Last modified 14 months ago

Don't add each piece of piecewise functions to the legend

Reported by: mjo Owned by: mjo
Priority: major Milestone: sage-5.0
Component: graphics Keywords:
Cc: kcrisman Work issues:
Report Upstream: N/A Reviewers: Karl-Dieter Crisman
Authors: Douglas McNeil, Michael Orlitzky Merged in: sage-5.0.beta9
Dependencies: Stopgaps:

Description

This was separated from #11225. The fix is given in  AskSage 925 by Douglas McNeil? (dsm).

Attachments

sage-trac_12651.patch Download (1.9 KB) - added by mjo 14 months ago.
Fix the duplicate legend entries and add a doctest

Change History

comment:1 Changed 14 months ago by kcrisman

  • Cc kcrisman added

comment:2 Changed 14 months ago by mjo

  • Status changed from new to needs_review
  • Authors set to Douglas McNeil, Michael Orlitzky

Changed 14 months ago by mjo

Fix the duplicate legend entries and add a doctest

comment:3 Changed 14 months ago by mjo

First patch had two lines with trailing whitespace, I just removed them.

comment:4 follow-up: ↓ 5 Changed 14 months ago by kcrisman

  • Status changed from needs_review to positive_review
  • Reviewers set to Karl-Dieter Crisman

It seems like everything is okay here. Certainly it fixes the problem, other keywords do apply to all pieces of the function.

When did the :trac: thing come in? This sounds vaguely familiar... at any rate, it works very nicely in the live doc!

comment:5 in reply to: ↑ 4 Changed 14 months ago by mjo

Replying to kcrisman:

When did the :trac: thing come in? This sounds vaguely familiar... at any rate, it works very nicely in the live doc!

5.0.beta4, apparently. Psyched that I no longer have to worry about word-wrapping "trac #12345" in the doctests.

comment:6 Changed 14 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta9
Note: See TracTickets for help on using tickets.