Ticket #12642 (closed defect: fixed)

Opened 15 months ago

Last modified 14 months ago

magma_free interface is broken

Reported by: was Owned by: was
Priority: major Milestone: sage-5.0
Component: interfaces Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: William Stein
Authors: Nils Bruin Merged in: sage-5.0.beta8
Dependencies: Stopgaps:

Description

Just like #10499,  http://magma.maths.usyd.edu.au/calc/ is broken again from sage: 

sage: magma_free('2+3')
Traceback (most recent call last):
...
IndexError: list index out of range

Attachments

trac_12642.patch Download (833 bytes) - added by nbruin 15 months ago.
trac_12642-referee.patch Download (983 bytes) - added by was 15 months ago.
apply this after the other patch

Change History

Changed 15 months ago by nbruin

comment:1 follow-up: ↓ 2 Changed 15 months ago by nbruin

  • Status changed from new to needs_review

That was interesting to see! As coded, it seemed a bit fragile. The replacement code should be less likely to throw errors. It will likely return junk when the site changes again, though.

comment:2 in reply to: ↑ 1 Changed 15 months ago by was

  • Status changed from needs_review to positive_review

Replying to nbruin:

That was interesting to see! As coded, it seemed a bit fragile. The replacement code should be less likely to throw errors. It will likely return junk when the site changes again, though.

Of course. I noticed that there is an "interesting" typo in the code "resluts", i.e., "re - sluts". I've posted a referee patch that fixes that typo.

Changed 15 months ago by was

apply this after the other patch

comment:3 Changed 14 months ago by jdemeyer

  • Reviewers set to William Stein
  • Authors set to Nils Bruin

comment:4 Changed 14 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta8
Note: See TracTickets for help on using tickets.