Ticket #12637 (closed defect: fixed)

Opened 15 months ago

Last modified 14 months ago

Follow-up to #4949: don't delete the current working directory

Reported by: jhpalmieri Owned by: GeorgSWeber
Priority: blocker Milestone: sage-5.0
Component: build Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Jeroen Demeyer
Authors: John Palmieri Merged in: sage-5.0.beta8
Dependencies: Stopgaps:

Description (last modified by jhpalmieri) (diff)

On Solaris, running rm -rf DIR fails if DIR is in the path of the current working directory. This happens in sage-spkg, so the temporary build directories $SAGE_BUILD_DIR/$PKG_NAME don't get deleted. Fix this by running cd ... first.

Apply trac_12637-cd-before-rm.patch Download to the root repo.

Attachments

trac_12637-cd-before-rm.patch Download (815 bytes) - added by jhpalmieri 15 months ago.
root repo

Change History

comment:1 Changed 15 months ago by jhpalmieri

  • Status changed from new to needs_review
  • Description modified (diff)

comment:2 Changed 15 months ago by jdemeyer

Could you just add a comment like 

# On Solaris, the current working directory cannot be deleted,
# so we "cd" out of $SAGE_BUILD_DIR/$PKG_NAME, see #12637.

comment:3 Changed 15 months ago by jhpalmieri

  • Description modified (diff)

Done. (Also changed the name of the patch file to match the ticket number.)

Changed 15 months ago by jhpalmieri

root repo

comment:4 Changed 15 months ago by jdemeyer

  • Status changed from needs_review to positive_review
  • Reviewers set to Jeroen Demeyer

comment:5 Changed 14 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta8
Note: See TracTickets for help on using tickets.