Ticket #12623 (closed defect: worksforme)

Opened 15 months ago

Last modified 9 months ago

PIL package doesn't know about debian multiarch

Reported by: Snark Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Julien Puydt
Authors: Merged in:
Dependencies: Stopgaps:

Description

I found that the PIL spkg has patches to deal with lib vs lib64 ; unfortunately, debian-based distributions have (or will soon have) another way to handle having various types of libraries on the same system.

I'm going to propose a patch which will add support for multiarch, based on the patch which is already used in debian for the python-imaging version 1.17. It is a very clean patch, as it only triggers on debian-based systems which have already made the switch.

Attachments

trac-12623.patch Download (2.9 KB) - added by Snark 15 months ago.
The promised patch for multiarch support
pil-1.1.6.p5.spkg Download (389.0 KB) - added by Snark 13 months ago.
Spkg with the patch applied

Change History

Changed 15 months ago by Snark

The promised patch for multiarch support

comment:1 Changed 15 months ago by Snark

  • Status changed from new to needs_review

comment:2 Changed 13 months ago by vbraun

The patch looks ok but do you also have an updated spkg?

Changed 13 months ago by Snark

Spkg with the patch applied

comment:3 Changed 10 months ago by jdemeyer

Please fill in your real name as Author.

comment:4 Changed 10 months ago by Snark

  • Authors set to Julien Puydt

comment:5 Changed 10 months ago by jdemeyer

  • Status changed from needs_review to needs_info

Why is this patch needed? I don't have any problems building PIL on multi-arch systems.

comment:6 Changed 9 months ago by Snark

I had a compilation issue while compiling the spkg in experimental settings ; as debian already packages this, I don't care anymore about the spkg being solid ; please close (why can't I close a ticket I opened?)

comment:7 Changed 9 months ago by jdemeyer

  • Milestone changed from sage-5.3 to sage-duplicate/invalid/wontfix

comment:8 Changed 9 months ago by jdemeyer

  • Status changed from needs_info to needs_review

comment:9 Changed 9 months ago by jdemeyer

  • Status changed from needs_review to positive_review
  • Reviewers set to Julien Puydt
  • Authors Julien Puydt deleted

comment:10 Changed 9 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to worksforme
Note: See TracTickets for help on using tickets.