Ticket #12621 (closed defect: duplicate)

Opened 15 months ago

Last modified 14 months ago

use bash for prereq install file

Reported by: jhpalmieri Owned by: GeorgSWeber
Priority: critical Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Jeroen Demeyer
Authors: Merged in:
Dependencies: #4949 Stopgaps:

Description (last modified by jdemeyer) (diff)

The script prereq-0.9-install starts with the line 

#!/bin/sh

As a result, when installing prereq on a Solaris machine, I see this: 

Starting prerequisite check.
Machine: SunOS mark2 5.10 Generic_127111-01 sun4u sparc SUNW,Sun-Blade-2500
base/prereq-0.9-install: !: not found
checking for a BSD-compatible install... ./install-sh -c

I think this is because of the line 

if ! [ -f "$SAGE_ROOT/spkg/base/$TARGET.tar" ]; then

in prereq-0.9-install. Using bash to run this script instead of sh fixes the problem. So I propose using bash for this script.

This will be fixed in #12112.

Attachments

trac_12621-prereq.patch Download (1.2 KB) - added by jhpalmieri 15 months ago.
trac_12621-prereq.v2.patch Download (654 bytes) - added by jhpalmieri 15 months ago.

Change History

Changed 15 months ago by jhpalmieri

comment:1 Changed 15 months ago by jhpalmieri

  • Status changed from new to needs_review
  • Dependencies set to #4949
  • Description modified (diff)

Changed 15 months ago by jhpalmieri

comment:2 Changed 15 months ago by jhpalmieri

  • Description modified (diff)
  • Summary changed from use bash for prereq and bzip2 install files to use bash for prereq install file

comment:3 Changed 14 months ago by jdemeyer

  • Status changed from needs_review to closed
  • Reviewers set to Jeroen Demeyer
  • Resolution set to duplicate
  • Description modified (diff)
  • Milestone changed from sage-5.0 to sage-duplicate/invalid/wontfix
Note: See TracTickets for help on using tickets.