Ticket #12532 (closed enhancement: fixed)

Opened 15 months ago

Last modified 9 days ago

plot3d transformations should take symbolic vectors

Reported by: jason Owned by: mmarco
Priority: minor Milestone: sage-5.10
Component: graphics Keywords: beginner
Cc: kcrisman Work issues:
Report Upstream: N/A Reviewers: Miguel Marco
Authors: Veronica Suaste Merged in: sage-5.10.beta4
Dependencies: Stopgaps:

Description

This works: 

var('r,theta,z,rho,phi')
cylindrical=[r*cos(theta), r*sin(theta), z]
plot3d(3,(theta,0,pi/2),(z,0,pi/2),transformation=cylindrical)

but this doesn't (but should work) 

cylindrical(r,theta,z)=[r*cos(theta), r*sin(theta), z]
plot3d(3,(theta,0,pi/2),(z,0,pi/2),transformation=cylindrical)

The problem is we pay too much attention to the type passed into the transformation argument. We should also allow symbolic vectors, as well as lists and tuples.

Attachments

trac_12532_transformation_symbolic_vector.patch Download (1.4 KB) - added by veronica 12 days ago.
Now the transformation also can be done with a symbolic vector

Change History

comment:1 Changed 15 months ago by jason

  • Keywords beginner added

Changed 12 days ago by veronica

Now the transformation also can be done with a symbolic vector

comment:2 Changed 12 days ago by mmarco

  • Owner changed from jason, was to mmarco
  • Reviewers set to mmarco

Looks good.

comment:3 Changed 12 days ago by mmarco

  • Status changed from new to needs_review

comment:4 Changed 12 days ago by mmarco

  • Status changed from needs_review to positive_review

comment:5 Changed 11 days ago by kcrisman

  • Reviewers changed from mmarco to Miguel Marco
  • Authors set to Veronica Suaste

PS to mmarco - your web link on the main Trac page gives Página no encontrada.

comment:6 Changed 11 days ago by mmarco

I know, i quited that position two years ago, and i have no personal webpage right now. I have to take care of that.

comment:7 Changed 9 days ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.10.beta4
Note: See TracTickets for help on using tickets.