Ticket #12512 (closed enhancement: fixed)
fixed point and periodic point of word morphism
| Reported by: | vdelecroix | Owned by: | vdelecroix |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.0 |
| Component: | combinatorics | Keywords: | word morphism |
| Cc: | tjolivet | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Timo Jolivet |
| Authors: | Vincent Delecroix | Merged in: | sage-5.0.beta10 |
| Dependencies: | Stopgaps: |
Description
This ticket is motivated by #12454. The aim is to implement new functionalities for word morphism (in sage.combinat.words.morphism) for computing individual as well as list of fixed point and periodic points.
Attachments
-
trac_12512-periodic_point.patch
(6.0 KB) -
added by jdemeyer 14 months ago.
Change History
comment:1 Changed 15 months ago by vdelecroix
- Status changed from new to needs_review
- Component changed from PLEASE CHANGE to combinatorics
comment:2 Changed 15 months ago by davidloeffler
- Status changed from needs_review to needs_work
There is a typo "dictionnary" at line 99, and a rogue non-ASCII character at line 130. At line 131, f.domain should be in double backticks and "try" --> "tries".
comment:4 Changed 15 months ago by tjolivet
- Status changed from needs_review to positive_review
Hi,
The patch applies well, the doc builds fine, the tests pass and the previous comments have been taken into account.
This is a very nice and useful patch, thank you.
You could add an example of a morphism without fixed points but with periodic points, for example:
sage: f = WordMorphism('a->b,b->c,c->ab')
sage: f.fixed_points()
[]
sage: f.periodic_points()
[[word: abbcbccabbccabcababbcbccabcababbccababbc..., word: bccabcababbccababbcabbcbccabcababbcabbcb..., word: cababbcabbcbccababbcbccabbccabcababbcabb...]]
comment:6 Changed 15 months ago by vdelecroix
Hi Timo!
Actually there is yet such an example in the documentation of periodic_points a->bab, b->aa.
Vincent
comment:8 Changed 14 months ago by jdemeyer
- Reviewers changed from tjolivet to Timo Jolivet
- Authors changed from vdelecroix to Vincent Delecroix
comment:10 Changed 14 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-5.0.beta10
