Ticket #12471 (closed defect: fixed)
real evaluation of symbolic expressions with complex coefficients
| Reported by: | burcin | Owned by: | burcin |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.0 |
| Component: | symbolics | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | Daniel Krenn |
| Authors: | Burcin Erocal | Merged in: | sage-5.0.beta7 |
| Dependencies: | Stopgaps: |
Description
This should work:
sage: cos(I).n() 1.54308063481524 sage: RR(cos(I)) <boom>
Attachments
-
trac_12471-complex_eval.patch
(3.0 KB) -
added by burcin 16 months ago.
Change History
comment:3 follow-up: ↓ 4 Changed 15 months ago by kcrisman
Daniel, thanks for looking at this. It looks pretty good, and don't worry about the mixed messages from the patchbot you mentioned on sage-devel - the only failure was
RuntimeError: Unexpected EOF from Gap executing UnorderedTuples([0, 1, 2, 3, 4, 5, 6, 7, 8, 9],1);
in the symbolic ring code, and that was on 4.8, not 5.0.beta3. If you think the code is right, isn't making some new assumption that would lead to a bug, is properly doctested, and passes tests, you should be good to give it positive review.
comment:4 in reply to: ↑ 3 Changed 15 months ago by dkrenn
- Status changed from needs_review to positive_review
Replying to kcrisman:
[...] the only failure was [...] in the symbolic ring code, and that was on 4.8, not 5.0.beta3.
On my machine with 4.8, I cannot produce that error...
If you think the code is right, isn't making some new assumption that would lead to a bug, is properly doctested, and passes tests, you should be good to give it positive review.
Yes, form my point of view it is a positive review.
