Ticket #12469 (closed defect: fixed)
RuntimeError raised by standard_factorization of a finite word
| Reported by: | htremblay | Owned by: | htremblay |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.1 |
| Component: | combinatorics | Keywords: | |
| Cc: | slabbe | Work issues: | |
| Report Upstream: | N/A | Reviewers: | André Apitzsch |
| Authors: | Hugo Tremblay | Merged in: | sage-5.1.beta0 |
| Dependencies: | Stopgaps: |
Description (last modified by aapitzsch) (diff)
sage: w=Word('babba')
sage: w.standard_factorization_of_lyndon_factorization()
Traceback (most recent call last)
...
RuntimeError: Bug in standard factorization of words
sage: w=Word('a')
sage: w.standard_factorization()
Traceback (most recent call last)
...
RuntimeError: Bug in standard factorization of words
Apply
Attachments
-
trac_12469.patch
(5.0 KB) -
added by htremblay 15 months ago.
- tested on sage-4.8
-
trac_12469_reviewer.patch
(1.1 KB) -
added by aapitzsch 13 months ago.
-
trac_12469_correction.patch
(928 bytes) -
added by htremblay 12 months ago.
- Applies on the previous patch
Change History
Changed 15 months ago by htremblay
-
attachment
trac_12469.patch
added
comment:1 Changed 15 months ago by htremblay
- Cc slabbe added
- Status changed from new to needs_review
- Authors set to Hugo Tremblay
comment:2 Changed 14 months ago by davidloeffler
- Status changed from needs_review to needs_work
Seems to be failing a doctest on 5.0.beta7 according to the patchbot. This looks completely trivial, but please check.
comment:4 Changed 13 months ago by aapitzsch
- Reviewers set to André Apitzsch
- Description modified (diff)
If you are okay with my patch you can change the status to positive review.
comment:5 Changed 13 months ago by htremblay
- Status changed from needs_review to positive_review
Tested on Sage Version 4.8.
comment:7 Changed 13 months ago by jdemeyer
- Status changed from positive_review to needs_work
Can you give the second patch a good commit message?
Changed 12 months ago by htremblay
-
attachment
trac_12469_correction.patch
added
Applies on the previous patch
comment:13 Changed 12 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-5.1.beta0
Note: See
TracTickets for help on using
tickets.
tested on sage-4.8