Ticket #12387 (new defect)

Opened 17 months ago

Last modified 16 months ago

Everything is not well with dense graph backends

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.11
Component: graph theory Keywords:
Cc: brunellus, rlm Work issues:
Report Upstream: N/A Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

We discovered in #12318 that some functions of sage/geometry/polyhedra and sage/geometry/triangulation/point_configuration.py return wrong results if Graph(sparse = True) is replaced by Graph(sparse = False)

Change History

comment:1 Changed 17 months ago by brunellus

The dense graph code doesn't support edge labeling, but the code in point_configuration.py rely on this. Maybe it is a mistake that dense_graph doesn't crash and burn whenever someone call add_edge(u, v, nonNone) -- but it is consistent with cases like

sage: G=Graph(multiedges=False)
sage: G.add_edge(0,1)
sage: G.add_edge(0,1)
sage: G.edges()
[(0, 1, None)]

comment:2 Changed 16 months ago by vbraun

I wrote the code for polyhedra. It is definitely a bug if the graph silently gives the wrong answer just because some backend doesn't support edge labels.

comment:3 Changed 16 months ago by brunellus

I started #12540 for this discussion.

I will investigate further if the lack of edge labels is the only source of the wrong results we spotted in #12318.

Note: See TracTickets for help on using tickets.