Ticket #12386 (closed defect: fixed)
[ARM] pickling issues in the matrix_mod2_dense code
| Reported by: | Snark | Owned by: | was |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.0 |
| Component: | pickling | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | Martin Albrecht |
| Authors: | Julien Puydt | Merged in: | sage-5.0.beta3 |
| Dependencies: | Stopgaps: |
Description
As discussed on the sage-devel mailing-list, that code uses "char" to read&write pickles on all platforms.
Unfortunately on ARM, "char" means "unsigned char", while on most other platforms, it means "signed char".
The solution is to make that code use "signed char" explicitly ; that way we unbreak the ARM pickles.
Attachments
-
pickle.patch
(731 bytes) -
added by Snark 16 months ago.
- Use "signed char" in matrix_mod2_dense for portability
-
pickle.2.patch
(996 bytes) -
added by Snark 16 months ago.
- hg export tip version of the patch
Change History
Changed 16 months ago by Snark
-
attachment
pickle.patch
added
comment:1 Changed 16 months ago by malb
- Status changed from new to needs_review
- Reviewers set to Martin Albrecht
Changes look reasonable, if this passes tests it should go in. Hence, positive review for now.
comment:3 Changed 16 months ago by jdemeyer
- Status changed from positive_review to needs_work
Patches should be made using "hg export tip" or similar, not "hg diff". Please re-upload a proper Mercurial changeset with a meaningful commit message.
Note: See
TracTickets for help on using
tickets.
Use "signed char" in matrix_mod2_dense for portability