Ticket #12382 (closed defect: fixed)

Opened 16 months ago

Last modified 14 months ago

Output of a two functions in sage.plot.plot3d.base is nondeterministic due to use of set

Reported by: roed Owned by: jason, was
Priority: minor Milestone: sage-5.0
Component: graphics Keywords:
Cc: jpflori Work issues:
Report Upstream: N/A Reviewers: Karl-Dieter Crisman
Authors: David Roe Merged in: sage-5.0.beta11
Dependencies: Stopgaps:

Description

Graphics3d.tachyon and Graphics3d.mtl_str both join string representations of the textures in Graphics3d.texture_set(). The order of elements pulled out of texture_set() can be different.

Attachments

12382.patch Download (1.3 KB) - added by roed 16 months ago.

Change History

Changed 16 months ago by roed

comment:1 Changed 16 months ago by roed

  • Status changed from new to needs_review

comment:2 Changed 15 months ago by jpflori

  • Cc jpflori added

comment:3 Changed 14 months ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman

I'm not quite sure why this happens - all is fine with or without on Mac, I know set is system-dependent? - but this definitely is a good fix and it's correct in the doctest. Can you tell me where it didn't work? I assume this was discovered due to a doctest failure, but it must have been on an uncommon platform, perhaps?

Anyway, modulo that, positive review.

comment:4 Changed 14 months ago by roed

It was discovered while developing the new doctesting framework at #12415.

comment:5 Changed 14 months ago by kcrisman

Ok, but I mean on what platform? I'm concerned to try to test that this works properly everywhere. Any other details would be helpful.

comment:6 Changed 14 months ago by roed

It was on OS X 10.6, but using different doctesting code (that hasn't been posted to #12415 yet). Currently I don't know of any platforms where this problem arises. The objective of this ticket is to make #12415 less of a patch-bomb. :-)

comment:7 Changed 14 months ago by kcrisman

  • Status changed from needs_review to positive_review

Ok... well, I guess since I tested on that platform I can say this is fine. But it seems odd to me that this would make a difference regarding which order the set happens in, if nothing else changed... Anyway, comparing pictures of 

G = icosahedron(color='red') + sphere((0,0,0), .6, color='yellow')

in Tachyon before and after the change they seem the same, and everything else seems good.

comment:8 Changed 14 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta11
Note: See TracTickets for help on using tickets.