Ticket #12373 (closed defect: fixed)

Opened 16 months ago

Last modified 15 months ago

Possible typo in Units Module Avogadro constant

Reported by: emil Owned by: burcin
Priority: minor Milestone: sage-5.0
Component: symbolics Keywords: units Avogadro constants
Cc: wstein Work issues:
Report Upstream: N/A Reviewers: William Stein
Authors: Sonseeahray Rucker, William Stein Merged in: sage-5.0.beta4
Dependencies: Stopgaps:

Description (last modified by burcin) (diff) 

sage: units.amount_of_substance.mole
sage: b.convert(units.amount_of_substance.elementary_entity)
sage: 6.02214179000000e23*elementary_entity

Nist gives 6.022141 2 9000000e23, maybe a typo?
 http://physics.nist.gov/cgi-bin/cuu/Value?na

Apply:

Attachments

my.patch Download (573 bytes) - added by ruckers 16 months ago.
This patches fixes a typo in Avogadro's constant in symbolic.units.pyx
trac_12373-part2.patch Download (633 bytes) - added by was 16 months ago.
part 2 patch -- add example to illustrate that the fix works.

Change History

comment:1 Changed 16 months ago by was

  • Owner changed from tbd to burcin
  • Type changed from PLEASE CHANGE to defect
  • Component changed from PLEASE CHANGE to symbolics

comment:2 Changed 16 months ago by was

A student (Sonseeahray Rucker) did this in my class, so a patch should appear here soon as a result.

Changed 16 months ago by ruckers

This patches fixes a typo in Avogadro's constant in symbolic.units.pyx

comment:3 Changed 16 months ago by ruckers

  • Status changed from new to needs_review

There's a typo in my typo patch description. The file being patched is symbol.units.py not .pyx.

comment:4 Changed 16 months ago by was

  • Description modified (diff)

Changed 16 months ago by was

part 2 patch -- add example to illustrate that the fix works.

comment:5 Changed 16 months ago by was

  • Status changed from needs_review to positive_review

I added a referee patch. This is a really simple little thing.

comment:6 Changed 16 months ago by burcin

  • Reviewers set to W. Stein
  • Description modified (diff)
  • Work issues check for typo deleted

comment:7 Changed 16 months ago by jdemeyer

Please write the full name including first name.

comment:8 Changed 16 months ago by was

  • Reviewers changed from W. Stein to William Stein
  • Authors changed from D. Ackermann, W. Stein to Sonseeahray Rucke, William Stein

comment:9 Changed 16 months ago by ruckers

  • Authors changed from Sonseeahray Rucke, William Stein to Sonseeahray Rucker, William Stein

Rucke correct to Rucker

comment:10 Changed 15 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta4
Note: See TracTickets for help on using tickets.