Ticket #12368 (closed defect: fixed)
Make "ratpoints" check whether -fnested-functions is supported by the compiler
| Reported by: | jdemeyer | Owned by: | tbd |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.0 |
| Component: | packages: standard | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | R. Andrew Ohana |
| Authors: | Jeroen Demeyer | Merged in: | sage-5.0.beta5 |
| Dependencies: | #12367 | Stopgaps: |
Description (last modified by jdemeyer) (diff)
On Darwin, ratpoints adds -fnested-functions (an Apple extension) to $CFLAGS causing failures when using gcc to compile.
spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/ratpoints-2.1.3.p2.spkg
Attachments
-
ratpoints-2.1.3.p1-p2.diff
(1.1 KB) -
added by jdemeyer 15 months ago.
- Diff for the ratpoints spkg, for review only
Change History
comment:1 Changed 16 months ago by jdemeyer
- Status changed from new to needs_review
- Description modified (diff)
comment:2 follow-up: ↓ 3 Changed 15 months ago by rohana
shouldn't you append testflags.sh -fnested-functions to CCFLAGS?
comment:3 in reply to: ↑ 2 ; follow-ups: ↓ 4 ↓ 5 ↓ 6 Changed 15 months ago by was
Replying to rohana:
shouldn't you append testflags.sh -fnested-functions to CCFLAGS?
I'm not sure. However, if he did then he would be changing how the spkg-install scripts works from before. It did not used to append to CCFLAGS -- it always wrote it from scratch. So I think appending or not is orthogonal to refereeing this patch; it could be another ticket.
My question is: what the heck is testcflags.sh? It doesn't exist on my OS X 10.7 install, or in Sage-5.0x as far as I can tell, or in this spkg... So I can't referee this package.
Changed 15 months ago by jdemeyer
-
attachment
ratpoints-2.1.3.p1-p2.diff
added
Diff for the ratpoints spkg, for review only
comment:5 in reply to: ↑ 3 Changed 15 months ago by jdemeyer
Replying to was:
I'm not sure. However, if he did then he would be changing how the spkg-install scripts works from before. It did not used to append to CCFLAGS -- it always wrote it from scratch.
I agree with R. Andrew, so I'm copying $CFLAGS to $CCFLAGS in spkg-install. Needs review.
comment:6 in reply to: ↑ 3 Changed 15 months ago by rohana
- Status changed from needs_review to positive_review
- Reviewers set to R. Andrew Ohana
Replying to was:
So I think appending or not is orthogonal to refereeing this patch; it could be another ticket.
Note that I did not mark it as needs work, I definitely agree that it is not necessary for refereeing this ticket. I would have given it a positive review regardless (since it did what it was supposed to do), but since it is a trivial change that improves the build process, and since he was already touching the CCFLAGS variable, I figured it couldn't hurt to actually have the global CFLAGS respected.
comment:7 in reply to: ↑ 4 Changed 15 months ago by was
Replying to jdemeyer:
Replying to was:
My question is: what the heck is testcflags.sh?
See #12367 (a dependency of this ticket).
It doesn't exist on my OS X 10.7 install
Did you look in $SAGE_ROOT/spkg/bin?
Yes, but I guess sage-5.0.beta2 is too old. I'll let somebody else referee this:
deep:~ wstein$ cd s/spkg/bin/ deep:bin wstein$ ls json_bundle.py sage-env testcc.sh text-collapse sage sage-spkg testcxx.sh text-expand deep:bin wstein$ sage -version Sage Version 5.0.beta2, Release Date: 2012-02-03
