Ticket #12286 (closed defect: fixed)
docstring for factorial function mentions unsupported algorithm keyword
| Reported by: | benjaminfjones | Owned by: | burcin |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-5.0 |
| Component: | symbolics | Keywords: | factorial function symbolics sd35.5 beginner |
| Cc: | kcrisman | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Karl-Dieter Crisman |
| Authors: | Peter Story | Merged in: | sage-5.0.beta0 |
| Dependencies: | Stopgaps: |
Description
The docstring for the global factorial function claims that an optional keyword algorithm can be specified, but currently this raises an error.
sage: factorial(4, algorithm='pari') ... TypeError: __call__() got an unexpected keyword argument 'algorithm'
sage: factorial(10, algorithm='gmp') ... TypeError: __call__() got an unexpected keyword argument 'algorithm'
Attachments
-
trac_12286_algorithmRemoval_nTweak.patch
(876 bytes) -
added by peter.story 16 months ago.
- Fixed line length.
Change History
comment:3 Changed 16 months ago by peter.story
- Status changed from new to needs_review
I removed all mention of the algorithm argument, and better defined what 'n' value can be provided (with the help of Benjamin Jones).
comment:6 Changed 16 months ago by peter.story
- Authors changed from peter.story, benjaminfjones to peter.story
comment:7 Changed 16 months ago by kcrisman
- Authors changed from peter.story to Peter Story
We put full names :)
comment:8 Changed 16 months ago by kcrisman
- Status changed from needs_review to needs_work
- Reviewers set to Karl-Dieter Crisman
This probably needs to be formatted so that the line isn't so long. You can do it exactly like the ones you deleted, in terms of the spacing.
Changed 16 months ago by peter.story
-
attachment
trac_12286_algorithmRemoval_nTweak.patch
added
Fixed line length.
comment:10 Changed 16 months ago by kcrisman
Yeah, this hasn't been used since before the Pynac switch. Anyway, looks good!
comment:12 Changed 16 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-5.0.beta0
Note: See
TracTickets for help on using
tickets.
