Ticket #1228 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

2.8.13.rc1: sage/rings/arith.py doctest failure

Reported by: mabshoff Owned by: mabshoff
Priority: critical Milestone: sage-2.8.13
Component: doctest Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

We get:

File "arith.py", line 2393:
     sage: continued_fraction_list(sqrt(4/19))
Expected:
     [0, 2, 5, 1, 1, 2, 1, 16, 1, 2, 1, 1, 5, 4, 5, 1, 1, 2, 1, 18]
Got:
     [0, 2, 5, 1, 1, 2, 1, 16, 1, 2, 1, 1, 5, 4, 5, 1, 1, 2, 1, 15, 2]

This is fallout from #1196:

With 2.8.12 we get:

sage: n(sqrt(4/19))
0.458831467741123

With 2.8.13.rc1 we get:

sage: n(sqrt(4/19))
0.458831467741124

Cheers,

Michael

Change History

Changed 3 years ago by mabshoff

  • status changed from new to assigned

Changed 3 years ago by was

Regarding #1228 change the doctest to the new answer.
It's actually much better.

Changed 3 years ago by mabshoff

  • status changed from assigned to closed
  • resolution set to fixed

Merged in 2.8.13.rc2.

Fixed the doctest directly :)

Note: See TracTickets for help on using tickets.