Ticket #12262 (closed enhancement: fixed)

Opened 17 months ago

Last modified 14 months ago

Bring Doctest coverage for sage/rings/finite_rings to 100%

Reported by: roed Owned by: mvngu
Priority: major Milestone: sage-5.0
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: David Loeffler
Authors: David Roe, David Loeffler Merged in: sage-5.0.beta11
Dependencies: #12062 Stopgaps:

Description

Part of metaticket #12024. While this ticket doesn't technically depend on #12260 and #12261, those element_ext_pari.py and integer_mod.pyx were split off into those two tickets.

This ticket addresses the files: 

finite_rings/element_givaro.pyx: 96% (61 of 63)
finite_rings/element_ntl_gf2e.pyx: 94% (53 of 56)
finite_rings/finite_field_givaro.py: 95% (20 of 21)
finite_rings/homset.py: 87% (7 of 8)
finite_rings/integer_mod_ring.py: 75% (33 of 44)

Attachments

12262.patch Download (18.7 KB) - added by roed 17 months ago.
12262-rebase.patch Download (18.5 KB) - added by davidloeffler 14 months ago.
roed's patch rebased for 5.0.beta8
12262-review.patch Download (2.9 KB) - added by davidloeffler 14 months ago.
Reviewer patch; apply over the rebased v5.0.beta8 patch

Change History

Changed 17 months ago by roed

comment:1 Changed 17 months ago by roed

  • Status changed from new to needs_review
  • Dependencies set to #12062
  • Authors set to David Roe

Depends on #12062 since that moved functions around in the finite_rings folder.

Changed 14 months ago by davidloeffler

roed's patch rebased for 5.0.beta8

Changed 14 months ago by davidloeffler

Reviewer patch; apply over the rebased v5.0.beta8 patch

comment:2 Changed 14 months ago by davidloeffler

  • Reviewers set to David Loeffler
  • Authors changed from David Roe to David Roe, David Loeffler

Apply 12262-rebase.patch, 12262-review.patch

This needed some minor rebasing to apply to 5.0.beta8 (I think because of #11900). Anyway, it's good stuff. I've uploaded my rebased version, and a reviewer patch that doctests one file that somehow escaped, and makes a minor, matter-of-taste change to the doctesting of _repr_ for homsets. If David or anyone else can sign off on my reviewer patch, then we can give this a positive review.

With both patches installed, every file in finite_rings gets 100% coverage except integer_mod.pyx, cf #12260.

comment:3 Changed 14 months ago by roed

  • Status changed from needs_review to positive_review

The review patch looks good to me.

comment:4 Changed 14 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta11
Note: See TracTickets for help on using tickets.