Ticket #12169 (closed enhancement: fixed)

Opened 17 months ago

Last modified 13 months ago

Adding Harary graphs to graph generators.

Reported by: fidelbarrera Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.0
Component: graph theory Keywords: graph generators, Harary graph
Cc: Work issues:
Report Upstream: N/A Reviewers: David Coudert, Nathann Cohen
Authors: Fidel Barrera-Cruz Merged in: sage-5.0.beta14
Dependencies: Stopgaps:

Description

The Harary graph H_{k,n} is a minimal k-connected graph on n vertices, where 2<=k<n.

About Harary graphs:

 http://mathworld.wolfram.com/HararyGraph.html

Attachments

trac_12169_1.patch Download (2.7 KB) - added by fidelbarrera 17 months ago.
Patch for Harary graphs
trac_12169-review.patch Download (4.3 KB) - added by dcoudert 14 months ago.

Change History

Changed 17 months ago by fidelbarrera

Patch for Harary graphs

comment:1 Changed 14 months ago by dcoudert

  • Status changed from new to needs_review
  • Reviewers set to David Coudert

Hello,

this patch was not set as needs review but was apparently waiting for it.

I wrote a small review patch mainly adding missing tests.

We now need someone to finalize the review.

Last edited 14 months ago by dcoudert (previous) (diff)

comment:2 Changed 14 months ago by ncohen

Hellooooooooo !!!

Could you add the HararyGraph? to the list of graph constructors at the beginning of the file ? As it is it does not appear in the index :-)

Once this is done, this patch can go !

Nathann

comment:3 Changed 14 months ago by ncohen

  • Status changed from needs_review to needs_work
  • Reviewers changed from David Coudert to David Coudert, Nathann Cohen
  • Authors set to Fidel Barrera-Cruz

Changed 14 months ago by dcoudert

comment:4 Changed 14 months ago by dcoudert

  • Status changed from needs_work to needs_review

Done inside review patch.

I let you conclude on the status of this patch.

comment:5 Changed 14 months ago by ncohen

  • Status changed from needs_review to positive_review

Well, then... :-)

Nathann

comment:6 Changed 13 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta14
Note: See TracTickets for help on using tickets.