Ticket #12144 (closed enhancement: fixed)
better document a technical confusing point in the Hidden Markov Model code
|Reported by:||was||Owned by:||amhou|
|Report Upstream:||N/A||Reviewers:||Jason Grout|
|Authors:||William Stein||Merged in:||sage-5.0.beta3|
Description (last modified by was) (diff)
I was reading the Continuous Hidden Markov Model code and trying to understand how probabilities are defined in a certain context, and got confused. So I added some comments to de-confuse me. Hence this patch.
There is small change in the code itself, where I had checked for "0" instead of checking for smaller than min_sd in one line. This makes the code (1) work much better with actual real world examples, and (2) is consistent with the old ghmm C library from sage-3.x that this code was supposed to replace.
See all #12146 for feature enhancements.
- Summary changed from better document a technical confusing points in the Hidden Markov Model code to better document a technical confusing point in the Hidden Markov Model code
- Status changed from needs_work to needs_review
- Description modified (diff)