Ticket #12090 (needs_review enhancement)

Opened 6 months ago

Last modified 7 weeks ago

Arrangements of pseudolines

Reported by: ncohen Owned by: mhampton
Priority: major Milestone: sage-5.0
Component: geometry Keywords:
Cc: Work issues: needs rebase
Report Upstream: N/A Reviewers:
Authors: Nathann Cohen Merged in:
Dependencies: #12159 #11634 Stopgaps:

Description

This module implements a class sage.geometry.pseudolines.PseudolinesArrangement? which can be used to encode an arrangement of pseudolines, and to go from one encoding to another.

It can also be used to plot an arrangement of pseudolines as a Wiring Diagram.

Attachments

trac_12090.patch Download (20.1 KB) - added by ncohen 7 weeks ago.

Change History

comment:1 Changed 6 months ago by ncohen

  • Status changed from new to needs_review

comment:2 Changed 6 months ago by ncohen

  • Status changed from needs_review to needs_work

comment:3 Changed 6 months ago by ncohen

  • Status changed from needs_work to needs_review

comment:4 Changed 6 months ago by ncohen

With more doctests and exceptions returned :-)

comment:5 Changed 7 weeks ago by davidloeffler

  • Status changed from needs_review to needs_work
  • Work issues set to needs rebase

This doesn't apply to 5.0.beta10 -- according to the patchbot there's a conflict in doc/en/reference/geometry.rst. It worked in 5.0.beta8 so the conflict is with something merged in 5.0.beta9 or beta10, perhaps #12159 or #11634.

comment:6 Changed 7 weeks ago by davidloeffler

  • Dependencies set to #12159 #11634

comment:7 Changed 7 weeks ago by ncohen

  • Status changed from needs_work to needs_review

Done ! :-)

Nathann

Changed 7 weeks ago by ncohen

comment:8 Changed 7 weeks ago by davidloeffler

That looks better. Notice the amusing line in the output of the patchbot test against 5.0.beta3: 

#11634 already applied (5.0.beta10 <= 5.0.beta3)

which explains why it's coming up with "Apply Failed". That's a patchbot bug, which I've reported on #12486.

Note: See TracTickets for help on using tickets.