Ticket #12056 (closed defect: fixed)

Opened 18 months ago

Last modified 18 months ago

sage -sdist/-bdist should use the current branch

Reported by: jdemeyer Owned by: leif
Priority: blocker Milestone: sage-4.8
Component: scripts Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Volker Braun
Authors: Jeroen Demeyer Merged in: sage-4.8.alpha3
Dependencies: Stopgaps:

Description (last modified by jdemeyer) (diff)

It seems that sage -sdist does not work properly with branches: it changes the version of the currently active branch but then packages the sage-main branch. I believe sage -sdist should sdist the currently active branch instead.

Analogously for sage -bdist.

Attachments

12056_sdist.patch Download (1.8 KB) - added by jdemeyer 18 months ago.
Apply to SCRIPTS repository

Change History

comment:1 Changed 18 months ago by jdemeyer

  • Description modified (diff)
  • Summary changed from sage -sdist should use the current branch to sage -sdist/-bdist should use the current branch

comment:2 Changed 18 months ago by jdemeyer

  • Status changed from new to needs_review

comment:3 Changed 18 months ago by jdemeyer

  • Status changed from needs_review to needs_work

bdist doesn't work properly.

Changed 18 months ago by jdemeyer

Apply to SCRIPTS repository

comment:4 Changed 18 months ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:5 Changed 18 months ago by vbraun

  • Status changed from needs_review to positive_review

Looks good!

comment:6 Changed 18 months ago by jdemeyer

  • Reviewers set to Volker Braun

comment:7 Changed 18 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.8.alpha3
Note: See TracTickets for help on using tickets.