Ticket #12012 (closed defect: fixed)
'make distclean' should clean up start.log, spkg/parallel_make.cfg
| Reported by: | jhpalmieri | Owned by: | GeorgSWeber |
|---|---|---|---|
| Priority: | blocker | Milestone: | sage-4.8 |
| Component: | build | Keywords: | |
| Cc: | jdemeyer, leif, mjo | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Michael Orlitzky |
| Authors: | John Palmieri | Merged in: | sage-4.8.alpha3 |
| Dependencies: | #11991, #11959 | Stopgaps: |
Description (last modified by jhpalmieri) (diff)
The patch (to the root repo) removes start.log and spkg/parallel_make.cfg when you run "make distclean". It no longer removes the ipython directory.
Attachments
-
trac_12012-distclean.patch
(791 bytes) -
added by jhpalmieri 18 months ago.
- root repo
Change History
comment:4 follow-up: ↓ 5 Changed 18 months ago by jhpalmieri
- Priority changed from major to blocker
I'm upgrading this to "blocker": running 'make distclean' shouldn't break your Sage distribution. It does now because it deletes the ipython directory. (The patch is also easy to review, I think.)
comment:5 in reply to: ↑ 4 Changed 18 months ago by jdemeyer
Replying to jhpalmieri:
It does now because it deletes the ipython directory. (The patch is also easy to review, I think.)
What exactly is the ipython directory needed for? I just deleted the ipython directory from a sage-4.8.alpha2 installation and everything still seems to work fine.
comment:6 follow-up: ↓ 7 Changed 18 months ago by jhpalmieri
Well, if you don't have a DOT_SAGE directory, the contents from SAGE_ROOT/ipython/ are copied to DOT_SAGE/ipython when DOT_SAGE is created.
comment:7 in reply to: ↑ 6 ; follow-up: ↓ 8 Changed 18 months ago by mjo
- Cc mjo added
Replying to jhpalmieri:
Well, if you don't have a DOT_SAGE directory, the contents from SAGE_ROOT/ipython/ are copied to DOT_SAGE/ipython when DOT_SAGE is created.
If you've just run make distclean, how will $DOT_SAGE get created?
comment:8 in reply to: ↑ 7 ; follow-up: ↓ 9 Changed 18 months ago by jhpalmieri
Replying to mjo:
Replying to jhpalmieri:
Well, if you don't have a DOT_SAGE directory, the contents from SAGE_ROOT/ipython/ are copied to DOT_SAGE/ipython when DOT_SAGE is created.
If you've just run make distclean, how will $DOT_SAGE get created?
I don't think I understand your question. The point of the patch here is that if you download a Sage source distribution and run make distclean, it breaks the distribution: the Sage root repository is no longer clean, and more importantly, if you have no $DOT_SAGE directory, then when you build and run Sage, it will fail when it tries to create DOT_SAGE/ipython/.
comment:9 in reply to: ↑ 8 Changed 18 months ago by mjo
- Status changed from needs_review to positive_review
- Reviewers set to Michael Orlitzky
Replying to jhpalmieri:
I don't think I understand your question. The point of the patch here is that if you download a Sage source distribution and run make distclean, it breaks the distribution: the Sage root repository is no longer clean, and more importantly, if you have no $DOT_SAGE directory, then when you build and run Sage, it will fail when it tries to create DOT_SAGE/ipython/.
Oh, sorry. I thought the ipython directory would be recreated after a build, and I had to make distclean and then sit through a full rebuild to see that's not the case.
I have reviewed:
- Confirm that spkg/parallel_make.cfg gets created/used in the following:
- spkg/install
- spkg/standard/deps
- Confirm that start.log should be removed.
- make distclean. Remove my ~/.sage directory. Build and try to start sage. Crashes per the ticket.
So, looks good.
comment:10 Changed 18 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-4.8.alpha3
