Ticket #12006 (closed defect: fixed)
sage-4.8 and magma-2.18 not playing well together
| Reported by: | mariah | Owned by: | was |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.0 |
| Component: | interfaces | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | Marco Streng |
| Authors: | William Stein | Merged in: | sage-5.0.beta4 |
| Dependencies: | Stopgaps: |
Description (last modified by mstreng) (diff)
Running
./sage -t -only-optional=magma devel/sage/sage
on a recent build of sage-4.7.2 where magma-2.17-13 (recent release) is installed (skynet/eno) gives the following errors:
The following tests failed:
sage -t -only-optional=magma "devel/sage/sage/rings/polynomial/multi_polynomial.pyx"
sage -t -only-optional=magma "devel/sage/sage/interfaces/magma.py"
sage -t -only-optional=magma "devel/sage/sage/schemes/elliptic_curves/ell_generic.py"
sage -t -only-optional=magma "devel/sage/sage/schemes/plane_conics/con_field.py"
Apply trac_12006.2.patch
Attachments
-
trac_12006.patch
(7.9 KB) -
added by was 16 months ago.
-
trac_12006.2.patch
(7.9 KB) -
added by was 16 months ago.
- differs from previous patch in exactly one letter "c" --> "a"
Change History
comment:1 Changed 16 months ago by was
- Summary changed from sage-4.7.2 and magma-2.17-13 not playing well together to sage-4.8 and magma-2.18 not playing well together
comment:5 Changed 16 months ago by mstreng
Your new patch is a superset of my patch, which has been needs_review for 7 weeks :(. I guess I'll have mine closed as duplicate then.
comment:6 Changed 16 months ago by mstreng
Apparently my Magma version V2.17-9 is not high enough for reviewing your patch. But the version-independent failures (like '1/1') should be fixed as soon as possible.
comment:7 follow-up: ↓ 8 Changed 16 months ago by mstreng
- Status changed from needs_review to needs_work
- Reviewers set to Marco Streng
The test added to sage/rings/number_field/number_field_element.pyx is incorrect: 'c' is not defined, and "optional - magma" is missing.
Changed 16 months ago by was
-
attachment
trac_12006.2.patch
added
differs from previous patch in exactly one letter "c" --> "a"
comment:8 in reply to: ↑ 7 ; follow-up: ↓ 9 Changed 16 months ago by was
- Status changed from needs_work to needs_review
Replying to mstreng:
The test added to sage/rings/number_field/number_field_element.pyx is incorrect: 'c' is not defined,
I've posted a new patch with it changed to 'a'
and "optional - magma" is missing.
The test doesn't actually require magma (all it does is raise an exception), so it is not marked optional.
comment:9 in reply to: ↑ 8 Changed 16 months ago by mstreng
- Status changed from needs_review to positive_review
- Description modified (diff)
comment:10 Changed 15 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-5.0.beta4
