Ticket #11971 (closed defect: fixed)

Opened 19 months ago

Last modified 18 months ago

get_memory_usage() doctest failure

Reported by: jdemeyer Owned by: mvngu
Priority: minor Milestone: sage-4.8
Component: doctest coverage Keywords:
Cc: justin Work issues:
Report Upstream: N/A Reviewers: Justin Walker
Authors: Jeroen Demeyer Merged in: sage-4.8.alpha2
Dependencies: Stopgaps:

Description

Justin reports on sage-release:

Built from scratch on Mac OS X, 10.6.8 (Dual 6-Core Xeon) w/o problems.  Testing (ptestlong) yielded one failure:
----------------------------------------------------------------------
The temporary doctesting directory
   /Users/justin/.sage/tmp/Zippo.local-33453
was not removed: it is not empty, presumably because doctests
failed or doctesting was interrupted.

----------------------------------------------------------------------

The following tests failed:

	sage -t  -long -force_lib devel/sage/sage/misc/getusage.py # 1 doctests failed
----------------------------------------------------------------------
**********************************************************************
File "/Users/Sage/sage-4.7.2.rc1/devel/sage-main/sage/misc/getusage.py", line 93
:
    sage: get_memory_usage(t)          # amount of memory more than when we defined t.
Expected:
    0.0
Got:
    0.25
**********************************************************************

Attachments

11971_getrusage.patch Download (2.4 KB) - added by jdemeyer 19 months ago.

Change History

comment:1 Changed 19 months ago by leif

EXAMPLES: should now be EXAMPLES:: (i.e., with a double-colon).

The program names (prstat and top etc.) should be typeset in monospaced / typewriter font, i.e. for example ``prstat`` instead of 'prstat'.

Changed 19 months ago by jdemeyer

comment:2 Changed 19 months ago by leif

Ok, new patch looks good (although I'd also use ``t`` instead of `t`, since it is a Python identifier rather than some mathematical variable or symbol), but Justin should test it and give it positive review.

comment:3 Changed 19 months ago by leif

P.S.: FWIW, applies to rc0 and passes tests on Ubuntu 10.04.3 x86_64.

comment:4 Changed 19 months ago by justin

  • Summary changed from get_memory_usage() doctest failure to get_memory_usage() doctest failure (positive_review)

I can't now reproduce the doctest failure; maybe cosmic rays are to blame.

In any case, the doctests all pass with the patch applied; the changes seem reasonable.

comment:5 Changed 19 months ago by jdemeyer

  • Priority changed from blocker to minor
  • Reviewers set to Justin Walker
  • Status changed from new to needs_review
  • Authors set to Jeroen Demeyer

comment:6 Changed 19 months ago by jdemeyer

  • Status changed from needs_review to positive_review
  • Summary changed from get_memory_usage() doctest failure (positive_review) to get_memory_usage() doctest failure

comment:7 Changed 18 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.8.alpha2
Note: See TracTickets for help on using tickets.