id summary reporter owner description type status priority milestone component resolution keywords cc work_issues upstream reviewer author merged dependencies stopgaps 11673 is_unit not properly implemented for algebraic integers bober davidloeffler "Here is an example: {{{ sage: K. = NumberField(x^2 - x - 1) sage: OK = K.ring_of_integers() sage: OK(13).is_unit() # should be false! True sage: OK(1/13) --------------------------------------------------------------------------- TypeError Traceback (most recent call last) /home/bober/ in () /home/bober/sage/local/lib/python2.6/site-packages/sage/structure/parent.so in sage.structure.parent.Parent.__call__ (sage/structure/parent.c:7102)() /home/bober/sage/local/lib/python2.6/site-packages/sage/structure/coerce_maps.so in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (sage/structure/coerce_maps.c:3254)() /home/bober/sage/local/lib/python2.6/site-packages/sage/structure/coerce_maps.so in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (sage/structure/coerce_maps.c:3157)() /home/bober/sage/local/lib/python2.6/site-packages/sage/rings/number_field/order.pyc in _element_constructor_(self, x) 1049 V, _, embedding = self._K.vector_space() 1050 if not embedding(x) in self._module_rep: -> 1051 raise TypeError, ""Not an element of the order."" 1052 return self._element_type(self, x) 1053 TypeError: Not an element of the order. }}} This does not seem to be limited to quadratic fields. Apply [attachment:11673.2.patch]." defect closed major sage-5.0 number fields fixed sd35 N/A David Loeffler Johan Bosman sage-5.0.beta1