Ticket #11627 (closed enhancement: fixed)
Turn Fan(discard_warning) into an error
| Reported by: | vbraun | Owned by: | mhampton |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.7.2 |
| Component: | geometry | Keywords: | |
| Cc: | novoselt | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Volker Braun |
| Authors: | Andrey Novoseltsev | Merged in: | sage-4.7.2.alpha3 |
| Dependencies: | Stopgaps: |
Description (last modified by vbraun) (diff)
There is no easy way to re-enable the warning after it has been shown once. A typical use case is that you have a mistake in your fan data and you want to fix it. The fact that the warning for duplicate cones is only shown once in the Sage session is very annoying.
Attachments
-
trac_11627_make_fan_raise_errors.patch
(4.8 KB) -
added by vbraun 22 months ago.
- Initial patch
-
trac_11627_alternative.patch
(10.8 KB) -
added by novoselt 22 months ago.
Change History
comment:1 Changed 22 months ago by novoselt
- Owner changed from AlexGhitza to mhampton
- Component changed from algebraic geometry to geometry
comment:2 Changed 22 months ago by vbraun
I do have a patch, I just haven't had the time to finish it.
comment:3 Changed 22 months ago by novoselt
Namewise, how about replacing disacard_warning, which will not make sense anymore, with discard_faces=False that can be set to True to allow it?
Changed 22 months ago by vbraun
-
attachment
trac_11627_make_fan_raise_errors.patch
added
Initial patch
comment:4 Changed 22 months ago by vbraun
Here is my take on it. I renamed it to check_duplicate_cones=<bool> to make clear that it is related to the check optional argument.
comment:5 Changed 22 months ago by vbraun
- Status changed from new to needs_review
- Authors set to Volker Braun
Any thoughts on the patch?
comment:6 Changed 22 months ago by novoselt
Hi Volker, sorry for the delay - travel/jetlag/work ;-)
Discarding faces and repeated cones is quite natural when they come from some construction and I have already wished a few times that it would be possible to drop them without using check=True option which does much more work. In fact, that's the reason why there is a function discard_faces. So I propose this patch which adds a discard_faces=False keyword which works independently of check. I have also fixed the code and documentation pieces that were relying on the old behaviour, I don't get now any errors for tests in geometry or schemes directories.
OK, I'll change it ;-)