Changes between Initial Version and Version 2 of Ticket #11597


Ignore:
Timestamp:
07/27/11 12:26:03 (22 months ago)
Author:
novoselt
Comment:

I've changed the documentation a little and replaced d for codimension with c as otherwise I was getting very confused thinking of d as dimension. I also switched the function to automatic caching and made it reuse codimension smoothness computation. If everything looks OK, please switch to positive review!

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11597

    • Property Status changed from new to needs_review
    • Property Authors changed from to Volker Braun
    • Property Cc novoselt added
    • Property Keywords toric added
    • Property Reviewers changed from to Andrey Novoseltsev

  • Ticket #11597 – Description

    initial v2  
    11This patch adds a method `dimension_singularities()` to toric varieties that computes the dimension of the singular set. This is usually one of the first questions one has, so I find it rather convenient to have a method for it. It also adds an optional `fan.is_smooth(codim=d)` argument for expert use, though in practice I think its easy to get confused with dimension and codimension so I did '''not''' add a similar optional argument to `toric_variety.is_smooth()`. 
     2 
     3'''Apply:''' 
     4 1. [attachment:trac_11597_fan_smooth_dimension.patch] 
     5 1. [attachment:trac_11597_reviewer.patch]