Ticket #11406 (closed defect: fixed)
improve plot documentation
| Reported by: | jason | Owned by: | jason, was |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.7.1 |
| Component: | graphics | Keywords: | beginner |
| Cc: | kcrisman, ryan | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Karl-Dieter Crisman |
| Authors: | Jason Grout | Merged in: | sage-4.7.1.alpha3 |
| Dependencies: | Stopgaps: |
Description (last modified by kcrisman) (diff)
Here are some improvements to the plot documentation, specifically with the linestyle. It also works around a possible bug in matplotlib in setting up the drawstyle of a line (so I marked this defect).
Attachments
-
trac-11406-plot-docs.patch
(9.9 KB) -
added by jason 2 years ago.
-
trac-11406-plot-docs-right-commit-message.patch
(10.0 KB) -
added by kcrisman 2 years ago.
Change History
comment:1 Changed 2 years ago by jason
- Cc kcrisman, ryan added
- Keywords beginner added
- Status changed from new to needs_review
- Authors set to Jason Grout
comment:4 Changed 2 years ago by kcrisman
- Status changed from needs_review to positive_review
- Reviewers set to Karl-Dieter Crisman
matplotlib is insanely awesome.
sage: plot(sin,-5,5,linestyle='',marker='$\spadesuit$', markeredgecolor='red',markerfacecolor='green')
Love this.
Did you report the possible bug upstream? Of course it wasn't even there before to be seen (in the doc). This does fix the problem.
Interesting that you say it answer the PREP question (which it does) - I would have just told someone to use points(list) rather than line(list). But this is still good to add to the doc in plot.py, which is all most people will look at.
This looks great - positive review.
comment:5 Changed 2 years ago by kcrisman
- Status changed from positive_review to needs_work
Whoops - except for the commit message.
:(
comment:6 Changed 2 years ago by jason
Our points command needs to be drastically improved. It doesn't take hardly any options right now.
I'll try to fix the commit message soon.
