Ticket #11389 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

Speed up list * Integer

Reported by: robertwb Owned by: tbd
Priority: major Milestone: sage-4.7.1
Component: performance Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Mike Hansen
Authors: Robert Bradshaw Merged in: sage-4.7.1.alpha3
Dependencies: Stopgaps:

Description

Despite resolving the performance regression at #10548, there is still a massive overhead. This ticket mostly eliminates that. (I experimented with adding an explicit Action, but the gain was minimal.)

Attachments

11389-integer-sequence.patch Download (10.6 KB) - added by robertwb 2 years ago.

Change History

comment:1 Changed 2 years ago by robertwb

  • Status changed from new to needs_review

Essentially, I allowed the acted upon set of an action to be a non-parent to allow for the fast path in this (and similar) cases.

comment:2 Changed 2 years ago by jdemeyer

  • Authors set to Robert Bradshaw

Changed 2 years ago by robertwb

comment:3 Changed 2 years ago by mhansen

  • Status changed from needs_review to positive_review
  • Reviewers set to Mike Hansen

Looks good to me.

comment:4 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.7.1.alpha3
Note: See TracTickets for help on using tickets.