Ticket #11371 (closed defect: fixed)
Error in MILP documentation
| Reported by: | kcrisman | Owned by: | mvngu |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-4.7.1 |
| Component: | documentation | Keywords: | |
| Cc: | ncohen | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Karl-Dieter Crisman |
| Authors: | Nathann Cohen | Merged in: | sage-4.7.1.alpha3 |
| Dependencies: | Stopgaps: |
Description
The (English) knapsack documentation in the thematic tutorial for MILP has an "oops" moment.
p.add_constraint(sum(weight[o] * taken[o] for o in L) <= C)
does not have the correct corresponding typeset thing, which instead has the sum of usefulness times taken less than or equal to C.
Perhaps this was introduced in the translation process? Anyway, should be easy to fix.
Attachments
-
trac_11371.patch
(1016 bytes) -
added by ncohen 2 years ago.
Change History
comment:1 Changed 2 years ago by ncohen
- Status changed from new to needs_review
- Authors set to Nathann Cohen
comment:2 follow-up: ↓ 3 Changed 2 years ago by kcrisman
Don't worry about the divers; in English, it's an old spelling of "diverse", or various - presumably from the time that Old/Middle? French was busy turning Anglo-Saxon into Middle English... :)
comment:3 in reply to: ↑ 2 Changed 2 years ago by ncohen
Replying to kcrisman:
Don't worry about the divers; in English, it's an old spelling of "diverse", or various - presumably from the time that Old/Middle? French was busy turning Anglo-Saxon into Middle English... :)
:-D
Good to know !
Then, do you think I should turn it back to "divers", is "random_stuff_" better or worse to an english tongue ? :-)
Nathann
comment:4 Changed 2 years ago by kcrisman
- Status changed from needs_review to positive_review
- Reviewers set to Karl-Dieter Crisman
No, random stuff is definitely better than 'divers'! Just sayin' that it was at least plausible to a sufficiently well-read English speaker.
Applies fine and looks fine and tests fine. Positive review.
That's perfectly right ^^;
The typeset version of the LP did not even depends on the weights....Fixed !
And there was also a variable named "divers" which I guess does not mean anything outside of french ... Thanks ! :-)
Nathann